Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable26] emit an event when a message is logged #38815

Merged
merged 2 commits into from Oct 11, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/composer/composer/autoload_classmap.php
Expand Up @@ -473,6 +473,7 @@
'OCP\\Lock\\ManuallyLockedException' => $baseDir . '/lib/public/Lock/ManuallyLockedException.php',
'OCP\\Lockdown\\ILockdownManager' => $baseDir . '/lib/public/Lockdown/ILockdownManager.php',
'OCP\\Log\\Audit\\CriticalActionPerformedEvent' => $baseDir . '/lib/public/Log/Audit/CriticalActionPerformedEvent.php',
'OCP\\Log\\BeforeMessageLoggedEvent' => $baseDir . '/lib/public/Log/BeforeMessageLoggedEvent.php',
'OCP\\Log\\IDataLogger' => $baseDir . '/lib/public/Log/IDataLogger.php',
'OCP\\Log\\IFileBased' => $baseDir . '/lib/public/Log/IFileBased.php',
'OCP\\Log\\ILogFactory' => $baseDir . '/lib/public/Log/ILogFactory.php',
Expand Down
1 change: 1 addition & 0 deletions lib/composer/composer/autoload_static.php
Expand Up @@ -506,6 +506,7 @@ class ComposerStaticInit749170dad3f5e7f9ca158f5a9f04f6a2
'OCP\\Lock\\ManuallyLockedException' => __DIR__ . '/../../..' . '/lib/public/Lock/ManuallyLockedException.php',
'OCP\\Lockdown\\ILockdownManager' => __DIR__ . '/../../..' . '/lib/public/Lockdown/ILockdownManager.php',
'OCP\\Log\\Audit\\CriticalActionPerformedEvent' => __DIR__ . '/../../..' . '/lib/public/Log/Audit/CriticalActionPerformedEvent.php',
'OCP\\Log\\BeforeMessageLoggedEvent' => __DIR__ . '/../../..' . '/lib/public/Log/BeforeMessageLoggedEvent.php',
'OCP\\Log\\IDataLogger' => __DIR__ . '/../../..' . '/lib/public/Log/IDataLogger.php',
'OCP\\Log\\IFileBased' => __DIR__ . '/../../..' . '/lib/public/Log/IFileBased.php',
'OCP\\Log\\ILogFactory' => __DIR__ . '/../../..' . '/lib/public/Log/ILogFactory.php',
Expand Down
7 changes: 7 additions & 0 deletions lib/private/EventDispatcher/EventDispatcher.php
Expand Up @@ -27,6 +27,7 @@
*/
namespace OC\EventDispatcher;

use OC\Log;
use Psr\Log\LoggerInterface;
use function get_class;
use OC\Broadcast\Events\BroadcastEvent;
Expand Down Expand Up @@ -54,6 +55,12 @@ public function __construct(SymfonyDispatcher $dispatcher,
$this->dispatcher = $dispatcher;
$this->container = $container;
$this->logger = $logger;

// inject the event dispatcher into the logger
// this is done here because there is a cyclic dependency between the event dispatcher and logger
if ($this->logger instanceof Log or $this->logger instanceof Log\PsrLoggerAdapter) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if ($this->logger instanceof Log or $this->logger instanceof Log\PsrLoggerAdapter) {
if ($this->logger instanceof Log || $this->logger instanceof Log\PsrLoggerAdapter) {

This is a backport so it should be left as-is, but we usually use ||/&& and not or/and

$this->logger->setEventDispatcher($this);
}
}

public function addListener(string $eventName,
Expand Down
16 changes: 16 additions & 0 deletions lib/private/Log.php
Expand Up @@ -38,6 +38,8 @@

use Exception;
use Nextcloud\LogNormalizer\Normalizer;
use OCP\EventDispatcher\IEventDispatcher;
use OCP\Log\BeforeMessageLoggedEvent;
use OCP\ILogger;
use OCP\IUserSession;
use OCP\Log\IDataLogger;
Expand Down Expand Up @@ -65,6 +67,7 @@ class Log implements ILogger, IDataLogger {
private ?bool $logConditionSatisfied = null;
private ?Normalizer $normalizer;
private ?IRegistry $crashReporters;
private ?IEventDispatcher $eventDispatcher;

/**
* @param IWriter $logger The logger that should be used
Expand All @@ -91,6 +94,11 @@ public function __construct(
$this->normalizer = $normalizer;
}
$this->crashReporters = $registry;
$this->eventDispatcher = null;
}

public function setEventDispatcher(IEventDispatcher $eventDispatcher) {
$this->eventDispatcher = $eventDispatcher;
}

/**
Expand Down Expand Up @@ -209,6 +217,10 @@ public function log(int $level, string $message, array $context = []) {
$app = $context['app'] ?? 'no app in context';
$entry = $this->interpolateMessage($context, $message);

if ($this->eventDispatcher) {
$this->eventDispatcher->dispatchTyped(new BeforeMessageLoggedEvent($app, $level, $entry));
}

try {
if ($level >= $minLevel) {
$this->writeLog($app, $entry, $level);
Expand Down Expand Up @@ -331,6 +343,10 @@ public function logException(Throwable $exception, array $context = []) {

array_walk($context, [$this->normalizer, 'format']);

if ($this->eventDispatcher) {
$this->eventDispatcher->dispatchTyped(new BeforeMessageLoggedEvent($app, $level, $data));
}

try {
if ($level >= $minLevel) {
if (!$this->logger instanceof IFileBased) {
Expand Down
5 changes: 5 additions & 0 deletions lib/private/Log/PsrLoggerAdapter.php
Expand Up @@ -26,6 +26,7 @@
namespace OC\Log;

use OC\Log;
use OCP\EventDispatcher\IEventDispatcher;
use OCP\ILogger;
use OCP\Log\IDataLogger;
use Psr\Log\InvalidArgumentException;
Expand All @@ -42,6 +43,10 @@ public function __construct(Log $logger) {
$this->logger = $logger;
}

public function setEventDispatcher(IEventDispatcher $eventDispatcher) {
$this->logger->setEventDispatcher($eventDispatcher);
}

private function containsThrowable(array $context): bool {
return array_key_exists('exception', $context) && $context['exception'] instanceof Throwable;
}
Expand Down
78 changes: 78 additions & 0 deletions lib/public/Log/BeforeMessageLoggedEvent.php
@@ -0,0 +1,78 @@
<?php

declare(strict_types=1);
/**
* @copyright Copyright (c) 2023 Robin Appelman <robin@icewind.nl>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/

namespace OCP\Log;

use OCP\EventDispatcher\Event;

/**
* Even for when a log item is being logged
*
* @since 26.0.7
*/
class BeforeMessageLoggedEvent extends Event {
private int $level;
private string $app;
private $message;

/**
* @since 28.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all @since annotations should reflect the target version of the backport

*/
public function __construct(string $app, int $level, $message) {
$this->level = $level;
$this->app = $app;
$this->message = $message;
}

/**
* Get the level of the log item
*
* @return int
* @since 28.0.0
*/
public function getLevel(): int {
return $this->level;
}


/**
* Get the app context of the log item
*
* @return string
* @since 28.0.0
*/
public function getApp(): string {
return $this->app;
}


/**
* Get the message of the log item
*
* @return string
* @since 28.0.0
*/
public function getMessage(): string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#38843 was not backported, wrong type.

return $this->message;
}
}