Fix files API route names #38830
Merged
Fix files API route names #38830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jld3103 <jld3103yt@gmail.com>
juliushaertl
approved these changes
Jun 15, 2023
come-nc
approved these changes
Jun 15, 2023
|
Does that mean the examples in https://docs.nextcloud.com/server/latest/developer_manual/basics/routing.html are incorrect @provokateurin? |
|
No, those seem to be all correct. |
|
backport? |
|
Not needes, it worked just fine before this change (see issue description) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The route names should have the correct controller names. It only worked before this change because the class matching is case-insensitive.
Checklist