Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix user log.condition feature #38881

Merged
merged 1 commit into from Jun 26, 2023
Merged

Fix user log.condition feature #38881

merged 1 commit into from Jun 26, 2023

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Jun 19, 2023 •
edited

Summary

User is not alway known at first log of a request, so we cannot cache log condition be request before we know the user.

Checklist

@come-nc come-nc added bug 3. to review Waiting for reviews labels Jun 19, 2023
@come-nc come-nc added this to the Nextcloud 28 milestone Jun 19, 2023
@come-nc come-nc self-assigned this Jun 19, 2023
@come-nc come-nc mentioned this pull request Jun 19, 2023
Closed
9 tasks
@szaimen szaimen requested review from icewind1991, blizzz, a team and Fenn-CS and removed request for a team June 22, 2023 12:09
Fenn-CS
Fenn-CS approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@Fenn-CS Fenn-CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joshtrichards
Copy link
Member

This seems to work much better...

@come-nc
Copy link
Contributor Author

come-nc commented Jun 26, 2023

/backport to stable27

@come-nc
Copy link
Contributor Author

come-nc commented Jun 26, 2023

/backport to stable26

@come-nc
Copy link
Contributor Author

come-nc commented Jun 26, 2023

/backport to stable25

@come-nc
Fix user log.condition feature
8ed6086 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc requested a review from artonge June 26, 2023 08:08
@come-nc come-nc enabled auto-merge June 26, 2023 12:35
@come-nc come-nc disabled auto-merge June 26, 2023 15:25
@come-nc come-nc merged commit 2d81c04 into master Jun 26, 2023
20 of 28 checks passed
@come-nc come-nc deleted the fix/logcondition-user branch June 26, 2023 15:25
@backportbot-nextcloud

This comment was marked as resolved.

Sign in to view
@backportbot-nextcloud

This comment was marked as resolved.

Sign in to view
@backportbot-nextcloud

This comment was marked as resolved.

Sign in to view
This was referenced Aug 24, 2023
Merged
Merged
@miaulalala miaulalala mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@Fenn-CS Fenn-CS Fenn-CS approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@blizzz blizzz Awaiting requested review from blizzz

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews bug feature: logging
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

[Bug]: log.condition does not work per user!
4 participants
@come-nc @joshtrichards @artonge @Fenn-CS