Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't disable actions when saving share permissions #38888

Merged
merged 1 commit into from Jun 19, 2023
Merged

Don't disable actions when saving share permissions #38888

merged 1 commit into from Jun 19, 2023

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Jun 19, 2023 •
edited

@artonge artonge self-assigned this Jun 19, 2023
@artonge artonge added this to the Nextcloud 28 milestone Jun 19, 2023
@artonge artonge force-pushed the artonge/fix/dont_disable_action_during_save branch from d5850fe to 028851c Compare June 19, 2023 10:00
@artonge artonge requested review from a team, susnux, Fenn-CS and Pytal and removed request for a team June 19, 2023 10:04
@artonge artonge added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 19, 2023
szaimen
szaimen reviewed Jun 19, 2023
View reviewed changes
.htaccess Outdated Show resolved Hide resolved
@artonge
Don't disable actions when saving share permissions
fbde8f9 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/fix/dont_disable_action_during_save branch from 028851c to fbde8f9 Compare June 19, 2023 10:13
szaimen
szaimen approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test.

Thanks for fixing this so fast @artonge! :)

@szaimen szaimen merged commit 892a837 into master Jun 19, 2023
38 checks passed
@szaimen szaimen deleted the artonge/fix/dont_disable_action_during_save branch June 19, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@szaimen szaimen szaimen approved these changes

@susnux susnux Awaiting requested review from susnux susnux was automatically assigned from nextcloud/server-frontend

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-frontend

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews enhancement feature: sharing javascript
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

Sharing buttons getting disabled for a split-second should not change appearance
3 participants
@artonge @Pytal @szaimen