Add getDocBaseUrl on theming app #38900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
requested review from
a team,
ArtificialOwl,
icewind1991 and
Fenn-CS
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -163,6 +164,10 @@ | |||
| return (string)$this->config->getAppValue('theming', 'privacyUrl', ''); | |||
| } | |||
|
|
|||
| public function getDocBaseUrl() { | |||
| return (string)$this->config->getAppValue('theming', 'docBaseUrl', $this->docBaseUrl); | |||
Check notice
Code scanning / Psalm
RedundantCastGivenDocblockType Note
Signed-off-by: Lorenzo Tanganelli <lorenzo.tanganelli@hotmail.it>
tanganellilore
force-pushed
the
add_theming_doc_url
branch
from
ff8197a
to
cc239f5
Compare
|
fixed psalm |
|
@icewind1991 @ArtificialOwl @Fenn-CS Any chance to check this? |
come-nc
reviewed
Jun 27, 2023
| @@ -163,6 +165,10 @@ public function getPrivacyUrl() { | |||
| return (string)$this->config->getAppValue('theming', 'privacyUrl', ''); | |||
| } | |||
|
|
|||
| public function getDocBaseUrl() { | |||
There was a problem hiding this comment.
I do not understand where is this method used?
There was a problem hiding this comment.
Is used on the ? or i button on some personal/admin settings:
There was a problem hiding this comment.
@come-nc it's just extending from OC_Defaults
skjnldsv
approved these changes
Jun 29, 2023
come-nc
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With new theming introduced on nextcloud >25, we can customize DocBaseUrl only if we use "old fashion way", adding
defaults.phpunder/themes/<custom_theme>/.With this PR I simply added a
getDocBaseUrl()function, that will get themingdocBaseUrlconfig and will use for doc base url.It will fallback on the defaullt one if not found, in the same way as other function.
TODO
N/A
Checklist