Cast string type for trim() #38910
Merged
Cast string type for trim() #38910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
requested review from
a team,
ArtificialOwl,
icewind1991 and
Fenn-CS
and removed request for
a team
dartcafe
force-pushed
the
fix/nullish-trim-deprecation-warning
branch
from
9b31680
to
28b0dd5
Compare
Fenn-CS
reviewed
Jun 20, 2023
Fenn-CS
reviewed
Jun 20, 2023
- Fix various psalm issues - Add as much typing as possible while preserving stable API Signed-off-by: Carl Schwan <carl@carlschwan.eu> Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: Carl Schwan <carl@carlschwan.eu> Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com> Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
dartcafe
force-pushed
the
fix/nullish-trim-deprecation-warning
branch
from
213d396
to
2211721
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| public function handle(Event $event): void { | ||
| if (!($event instanceof CommentsEntityEvent)) { | ||
| // Unrelated | ||
| return; | ||
| } | ||
|
|
||
| $event->addEntityCollection('files', function ($name) { | ||
| $nodes = \OC::$server->getUserFolder()->getById((int)$name); | ||
| $event->addEntityCollection('files', function ($name): bool { |
Check notice
Code scanning / Psalm
MissingClosureParamType Note
| $event->addEntityCollection('files', function ($name) { | ||
| $nodes = \OC::$server->getUserFolder()->getById((int)$name); | ||
| $event->addEntityCollection('files', function ($name): bool { | ||
| $nodes = $this->rootFolder->getUserFolder($this->userId)->getById((int)$name); |
Check notice
Code scanning / Psalm
PossiblyNullArgument Note
| * | ||
| * @param array $mentions | ||
| * @return string[] containing the mentions, e.g. ['alice', 'bob'] | ||
| * @return list<string> containing the mentions, e.g. ['alice', 'bob'] |
Check notice
Code scanning / Psalm
MoreSpecificReturnType Note
Fenn-CS
approved these changes
Jun 20, 2023
|
The last commits come from the master branch. I can open a clean PR if necessary. |
icewind1991
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary