Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust admin setup check to increase warning to configure https #38915

Merged
merged 1 commit into from Jun 21, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Jun 20, 2023

Close #36582

Reason: Without https some important web functionality like "copy to clipboard" or "service workers" does not work!

Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen added the 3. to review Waiting for reviews label Jun 20, 2023
@szaimen szaimen added this to the Nextcloud 28 milestone Jun 20, 2023
@szaimen szaimen requested a review from a team June 20, 2023 20:55
@szaimen szaimen changed the title adjust admin setup check to increase warning to set up https adjust admin setup check to increase warning to configure https Jun 20, 2023
@szaimen szaimen requested review from rakekniven, Valdnet and a team June 20, 2023 21:38
@szaimen szaimen merged commit 5fb7ea2 into master Jun 21, 2023
37 checks passed
@szaimen szaimen deleted the enh/noid/increase-https-warning branch June 21, 2023 02:41
@szaimen
Copy link
Contributor Author

szaimen commented Jun 21, 2023

/backport to stable27

@szaimen
Copy link
Contributor Author

szaimen commented Jun 21, 2023

/backport to stable26

@szaimen
Copy link
Contributor Author

szaimen commented Jun 21, 2023

/backport to stable25

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@szaimen
Copy link
Contributor Author

szaimen commented Jun 21, 2023

/backport to stable27

@szaimen
Copy link
Contributor Author

szaimen commented Jun 21, 2023

/backport to stable26

@szaimen
Copy link
Contributor Author

szaimen commented Jun 21, 2023

/backport to stable25

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@szaimen
Copy link
Contributor Author

szaimen commented Jun 21, 2023

/backport to stable27

@szaimen
Copy link
Contributor Author

szaimen commented Jun 21, 2023

/backport to stable26

@szaimen
Copy link
Contributor Author

szaimen commented Jun 21, 2023

/backport to stable25

@olodar
Copy link

olodar commented Jul 20, 2023

So what? Are you understand force users to use https is a stupid idea? https has much lower security than VPN encryption, this is first. Second, https in lan is not need, as in VPN.
You can simply warn that using via http may be unsecure, but this case is only when you're accesing from web (http://mysite.com).
Nextcloud developers mustn't force to use https!

@szaimen
Copy link
Contributor Author

szaimen commented Jul 20, 2023

It is not forced. It is just a warning. Also the things that we mentioned are actually enforced by the browser and not by us so no way to work around it.

@nextcloud nextcloud locked as resolved and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Copy link to clipboard broken when speeking plain http (https not affected) in 26.0.0.4 (beta 2)
4 participants