fix(eventdispatcher): Don't use all evaluating "or"

[nickvergessen]

Summary

or is always evaluating all expressions. There is no need to do this here, so in order to emphasize best practises it should be replaced with ||

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[come-nc]

Summary

or is always evaluating all expressions. There is no need to do this here, so in order to emphasize best practises it should be replaced with ||

Source?

https://www.php.net/manual/en/language.operators.logical.php does not state that and https://3v4l.org/06rEj shows second part is not evaluated if first one is true.

[nickvergessen]

Arg this is the wrong thing in my brain I can't forget. So it's not about evaluation but about priority. As per docs:

// The constant false is assigned to $f before the "or" operation occurs
// Acts like: (($f = false) or true)
$f = false or true;

So it's not a problem, until someone extracts the condition into a variable. But yeah still bad enough and we shouldn't use it.