Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(sab): Add profileUrl to SAB #38969

Merged
merged 1 commit into from Jul 3, 2023
Merged

enh(sab): Add profileUrl to SAB #38969

merged 1 commit into from Jul 3, 2023

Conversation

JohannesGGE
Copy link
Contributor

@JohannesGGE JohannesGGE commented Jun 23, 2023 •
edited

Summary

TODO

  • ...

Checklist

@JohannesGGE JohannesGGE added enhancement feature: dav integration feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) feature: carddav Related to CardDAV internals labels Jun 23, 2023
@JohannesGGE JohannesGGE self-assigned this Jun 23, 2023
tcitworld
tcitworld reviewed Jun 23, 2023
View reviewed changes
apps/dav/lib/CardDAV/Converter.php Outdated Show resolved Hide resolved
apps/dav/lib/CardDAV/Converter.php Outdated Show resolved Hide resolved
@JohannesGGE JohannesGGE force-pushed the enh/38944/add-profile-url-to-sab branch from 38d311a to 3388a34 Compare June 26, 2023 08:47
@JohannesGGE JohannesGGE force-pushed the enh/38944/add-profile-url-to-sab branch 2 times, most recently from 28d6ced to 15ca794 Compare June 26, 2023 12:08
@JohannesGGE JohannesGGE marked this pull request as ready for review June 26, 2023 12:09
@JohannesGGE JohannesGGE added the 3. to review Waiting for reviews label Jun 26, 2023
@ChristophWurst
Copy link
Member

You get bonus point for adjusting https://github.com/nextcloud/server/blob/master/apps/dav/tests/unit/CardDAV/ConverterTest.php ;)

The test can be run with NOCOVERAGE=1 ./autotest.sh sqlite apps/dav/tests/unit/CardDAV/ConverterTest.php

@ChristophWurst
Copy link
Member

The test fails and has to be adjusted

@ChristophWurst ChristophWurst marked this pull request as draft June 27, 2023 11:38
@JohannesGGE JohannesGGE force-pushed the enh/38944/add-profile-url-to-sab branch from 15ca794 to cc93c7b Compare June 27, 2023 12:27
@JohannesGGE JohannesGGE marked this pull request as ready for review June 27, 2023 12:28
@JohannesGGE JohannesGGE added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 3, 2023
@JohannesGGE
enh(sab): Add profileUrl to SAB
eda3824 
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
@JohannesGGE JohannesGGE force-pushed the enh/38944/add-profile-url-to-sab branch from cc93c7b to eda3824 Compare July 3, 2023 15:55
@JohannesGGE JohannesGGE merged commit c3dcd70 into master Jul 3, 2023
39 checks passed
@JohannesGGE JohannesGGE deleted the enh/38944/add-profile-url-to-sab branch July 3, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcitworld tcitworld tcitworld left review comments

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@miaulalala miaulalala miaulalala approved these changes

Assignees

@JohannesGGE JohannesGGE

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: carddav Related to CardDAV internals feature: dav feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write profile URL into system address book contact
4 participants
@JohannesGGE @ChristophWurst @tcitworld @miaulalala