Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses PHP8's constructor property promotion in core/Migrations #38974

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 3 additions & 5 deletions core/Migrations/Version13000Date20170718121200.php
Expand Up @@ -39,11 +39,9 @@
use OCP\Migration\SimpleMigrationStep;

class Version13000Date20170718121200 extends SimpleMigrationStep {
/** @var IDBConnection */
private $connection;

public function __construct(IDBConnection $connection) {
$this->connection = $connection;
public function __construct(
private IDBConnection $connection,
) {
}

public function preSchemaChange(IOutput $output, \Closure $schemaClosure, array $options) {
Expand Down
8 changes: 3 additions & 5 deletions core/Migrations/Version14000Date20180404140050.php
Expand Up @@ -35,11 +35,9 @@
* Auto-generated migration step: Please modify to your needs!
*/
class Version14000Date20180404140050 extends SimpleMigrationStep {
/** @var IDBConnection */
private $connection;

public function __construct(IDBConnection $connection) {
$this->connection = $connection;
public function __construct(
private IDBConnection $connection,
) {
}

public function name(): string {
Expand Down
8 changes: 3 additions & 5 deletions core/Migrations/Version16000Date20190427105638.php
Expand Up @@ -33,11 +33,9 @@
use OCP\Migration\SimpleMigrationStep;

class Version16000Date20190427105638 extends SimpleMigrationStep {
/** @var IDBConnection */
private $connection;

public function __construct(IDBConnection $connection) {
$this->connection = $connection;
public function __construct(
private IDBConnection $connection,
) {
}

/**
Expand Down
8 changes: 3 additions & 5 deletions core/Migrations/Version18000Date20190920085628.php
Expand Up @@ -36,11 +36,9 @@
use OCP\Migration\SimpleMigrationStep;

class Version18000Date20190920085628 extends SimpleMigrationStep {
/** @var IDBConnection */
protected $connection;

public function __construct(IDBConnection $connection) {
$this->connection = $connection;
public function __construct(
protected IDBConnection $connection,
) {
}

/**
Expand Down
8 changes: 3 additions & 5 deletions core/Migrations/Version18000Date20191014105105.php
Expand Up @@ -36,11 +36,9 @@
use OCP\Migration\IOutput;

class Version18000Date20191014105105 extends SimpleMigrationStep {
/** @var IDBConnection */
protected $connection;

public function __construct(IDBConnection $connection) {
$this->connection = $connection;
public function __construct(
protected IDBConnection $connection,
) {
}

/**
Expand Down
8 changes: 3 additions & 5 deletions core/Migrations/Version18000Date20191204114856.php
Expand Up @@ -32,11 +32,9 @@
use OCP\Migration\IOutput;

class Version18000Date20191204114856 extends SimpleMigrationStep {
/** @var IDBConnection */
protected $connection;

public function __construct(IDBConnection $connection) {
$this->connection = $connection;
public function __construct(
protected IDBConnection $connection,
) {
}

/**
Expand Down
8 changes: 3 additions & 5 deletions core/Migrations/Version20000Date20201109081918.php
Expand Up @@ -35,11 +35,9 @@
use OCP\Migration\SimpleMigrationStep;

class Version20000Date20201109081918 extends SimpleMigrationStep {
/** @var IDBConnection */
protected $connection;

public function __construct(IDBConnection $connection) {
$this->connection = $connection;
public function __construct(
protected IDBConnection $connection,
) {
}

/**
Expand Down
8 changes: 3 additions & 5 deletions core/Migrations/Version24000Date20211210141942.php
Expand Up @@ -37,11 +37,9 @@
*
*/
class Version24000Date20211210141942 extends SimpleMigrationStep {
/** @var IDBConnection */
protected $connection;

public function __construct(IDBConnection $connection) {
$this->connection = $connection;
public function __construct(
protected IDBConnection $connection,
) {
}

/**
Expand Down
8 changes: 3 additions & 5 deletions core/Migrations/Version24000Date20211230140012.php
Expand Up @@ -33,11 +33,9 @@
use OCP\Migration\SimpleMigrationStep;

class Version24000Date20211230140012 extends SimpleMigrationStep {
/** @var IDBConnection */
protected $connection;

public function __construct(IDBConnection $connection) {
$this->connection = $connection;
public function __construct(
protected IDBConnection $connection,
) {
}

public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
Expand Down
7 changes: 3 additions & 4 deletions core/Migrations/Version25000Date20221007010957.php
Expand Up @@ -38,10 +38,9 @@
*
*/
class Version25000Date20221007010957 extends SimpleMigrationStep {
protected IDBConnection $connection;

public function __construct(IDBConnection $connection) {
$this->connection = $connection;
public function __construct(
protected IDBConnection $connection,
) {
}

/**
Expand Down
2 changes: 1 addition & 1 deletion core/Migrations/Version27000Date20230309104325.php
Expand Up @@ -39,7 +39,7 @@
*/
class Version27000Date20230309104325 extends SimpleMigrationStep {
public function __construct(
private IDBConnection $connection
private IDBConnection $connection,
) {
}

Expand Down