Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore AppsSlideToggle feature #38988

Merged
merged 1 commit into from Jun 25, 2023
Merged

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv added this to the Nextcloud 28 milestone Jun 25, 2023
@skjnldsv skjnldsv requested review from solracsf and a team June 25, 2023 09:53
@skjnldsv skjnldsv self-assigned this Jun 25, 2023
@skjnldsv skjnldsv requested review from susnux, Fenn-CS and Pytal and removed request for a team June 25, 2023 09:53
@skjnldsv
Copy link
Member Author

/backport to stable27

@skjnldsv
Copy link
Member Author

/compile amend /

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is OC not (theoretically) private API? (just asking because in this case probably those apps should migrate?)

@skjnldsv
Copy link
Member Author

Is OC not (theoretically) private API? (just asking because in this case probably those apps should migrate?)

Those apps should indeed migrate, but we need to properly deprecate and publish some documents with an alternative

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@szaimen szaimen enabled auto-merge June 25, 2023 14:08
@szaimen szaimen merged commit 72156d7 into master Jun 25, 2023
38 checks passed
@szaimen szaimen deleted the fix/data-apps-slide-toggle branch June 25, 2023 14:16
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@szaimen
Copy link
Contributor

szaimen commented Jun 25, 2023

/backport to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@ShGKme
Copy link
Contributor

ShGKme commented Feb 8, 2024

Those apps should indeed migrate, but we need to properly deprecate and publish some documents with an alternative

@skjnldsv So, should we deprecate it in Nextcloud 29?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants