Migrate federation application to LoggerInterface #39018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
requested review from
a team,
ArtificialOwl,
icewind1991 and
Fenn-CS
and removed request for
a team
24 tasks
Fenn-CS
reviewed
Jun 26, 2023
| */ | ||
| public function execute(IJobList $jobList, ILogger $logger = null) { | ||
| public function start(IJobList $jobList): void { |
There was a problem hiding this comment.
This is a public method, just double checking to ensure you have checked for references in other parts of the code?
There was a problem hiding this comment.
Yes, the parent class OCP\BackgroundJob\Job is migrating from execute to start since 25, I think we should even deprecate execute since it’s always a problem for migrating away from ILogger.
There was a problem hiding this comment.
Is there an issue for that? If not I could create one and deprecate it rn.
There was a problem hiding this comment.
Actually I just saw that execute is already deprecated in IJob interface.
Maybe it would still be a good idea to mark it as deprecated in Job class as well.
artonge
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #32127
Migrate federation application from ILogger to LoggerInterface
Checklist