Fix root mounts not being setup in some cases #39044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
force-pushed
the
more-empty-mount-checking
branch
2 times, most recently
from
39893f0
to
8cf7451
Compare
icewind1991
force-pushed
the
more-empty-mount-checking
branch
from
8cf7451
to
c3c8b78
Compare
icewind1991
changed the title
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
more-empty-mount-checking
branch
from
c3c8b78
to
1eb3293
Compare
icewind1991
requested review from
a team,
ArtificialOwl,
Fenn-CS and
sorbaugh
and removed request for
a team
Fenn-CS
approved these changes
Sep 12, 2023
8 tasks
|
This fixes active breakage of production systems and updates to those, the corresponding bug is already 1,5y open. |
sorbaugh
approved these changes
Oct 13, 2023
|
/backport to stable27 |
|
/backport to stable26 |
|
Thanks a lot, much appreciated! |
This was referenced Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the root setup is triggered before the
filesystemapps are loaded. These are then loading during the filesystem wrapper setup, if the loading of an app attempts to interact with the filesystem, it will attempt to setup the filesystem recursively.This recursion is prevented by the
SetupManager, but that also means that the app loading code sees the filesystem with no mounts setup. Which will lead to errors.By moving the wrapper setup to before the recursion setup we can prevent this issue