Refactors lib/private/Lock

[fsamapoor]

Summary

Following previous PRs taking advantage of PHP8's constructor property promotion in /core/ namespace, I have also made the required adjustments to the classes in /lib/private/Lock namespace.

The improvements in this PR include:

• Using PHP8's constructor property promotion
• Using match expression
• Adding types to properties

Checklist

• Code is properly formatted
• Sign-off message is added to all commits

[Fenn-CS]

LGTM, thank you!

[come-nc]

I dislike the match uses, I find them a lot less readable.

Also there is a problem with how the $ttl property is handled, see comments.

[fsamapoor]

I dislike the match uses, I find them a lot less readable.

Also there is a problem with how the $ttl property is handled, see comments.

Thank you, Come, for reviewing the PR. I really appreciate the timely feedback. I'm suggesting changes that I believe will improve code readability. However, I have no hard feelings if you prefer to revert or disregard them, as you are the maintainer.

Having said that, I've received multiple positive feedbacks in previous PRs regarding the use of match statements, and I personally try to minimize the use of else statements as much as I can.

I've moved the ttl property to the parent class. Please review the changes and let me know if I should revert the match statements.

[come-nc]

Thank you, Come, for reviewing the PR. I really appreciate the timely feedback. I'm suggesting changes that I believe will improve code readability. However, I have no hard feelings if you prefer to revert or disregard them, as you are the maintainer.

Having said that, I've received multiple positive feedbacks in previous PRs regarding the use of match statements, and I personally try to minimize the use of else statements as much as I can.

I've moved the ttl property to the parent class. Please review the changes and let me know if I should revert the match statements.

Yes please revert the match statements. There is no need for minimizing the else statements, else is a perfectly fine language construct.
I only find match interesting for simple cases where an input value directly implies an output value. When there is more logic than that it quickly looks like perl oneliners.
And I especially find match(true) really non-intuitive.

[fsamapoor]

Thank you, Come, for reviewing the PR. I really appreciate the timely feedback. I'm suggesting changes that I believe will improve code readability. However, I have no hard feelings if you prefer to revert or disregard them, as you are the maintainer.
Having said that, I've received multiple positive feedbacks in previous PRs regarding the use of match statements, and I personally try to minimize the use of else statements as much as I can.
I've moved the ttl property to the parent class. Please review the changes and let me know if I should revert the match statements.

Yes please revert the match statements. There is no need for minimizing the else statements, else is a perfectly fine language construct. I only find match interesting for simple cases where an input value directly implies an output value. When there is more logic than that it quickly looks like perl oneliners. And I especially find match(true) really non-intuitive.

Done. Thank you for the explanation. Squashed the commits as well for a clean history.