Refactors /Metadata, /Migration, and /Net namespaces in /lib/private/ #39109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
requested review from
a team,
ArtificialOwl,
icewind1991 and
Fenn-CS
and removed request for
a team
Fenn-CS
requested changes
Jul 13, 2023
There was a problem hiding this comment.
You added return types to some functions so you might want to add type hints as well.
Please do verify, that the suggestions I made tie with the expected function types, for example $app does not have a function annotation at the top but I am guessing it would be a string.
Fenn-CS
approved these changes
Jul 14, 2023
artonge
approved these changes
Aug 17, 2023
fsamapoor
force-pushed
the
refactor_lib_private_metadata_migration_net
branch
2 times, most recently
from
c35f042
to
ac614bf
Compare
Merged
Merged
In lib/private namespace to improve code readability. Signed-off-by: Faraz Samapoor <fsa@adlas.at> Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
fsamapoor
force-pushed
the
refactor_lib_private_metadata_migration_net
branch
from
ac614bf
to
cbc47a9
Compare
ChristophWurst
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following previous PRs taking advantage of PHP8's constructor property promotion in
/core/namespace, I have also made the required adjustments to the classes in/lib/private/Metadata,/lib/private/Migration, and/lib/private/Netnamespaces.The improvements in this PR include:
Checklist