Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psalm: Enable more/less specific errors #39116

Merged
merged 1 commit into from Jul 4, 2023

Conversation

provokateurin
Copy link
Member

Summary

Adds more warnings if you set wrong return types. Very helpful for OpenAPI to ensure everything is typed correctly.
Should I commit the baseline file or not?

Checklist

@provokateurin provokateurin added this to the Nextcloud 28 milestone Jul 3, 2023
@provokateurin provokateurin force-pushed the feature/psalm-enable-more-less-specific branch from 72ea213 to b32613d Compare July 3, 2023 09:43
Signed-off-by: jld3103 <jld3103yt@gmail.com>
@provokateurin provokateurin force-pushed the feature/psalm-enable-more-less-specific branch from b32613d to cd91b77 Compare July 3, 2023 16:09
@blizzz blizzz requested a review from come-nc July 3, 2023 16:18
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit doubtful about LessSpecificReturnType, otherwise OK. Would ship baseline unless you want to fix them all right away (would recommend step by step)?

@provokateurin
Copy link
Member Author

A bit doubtful about LessSpecificReturnType

It's just for completeness.

Would ship baseline unless you want to fix them all right away

No, I don't want to fix them right now.

@provokateurin provokateurin merged commit 3117ec8 into master Jul 4, 2023
39 checks passed
@provokateurin provokateurin deleted the feature/psalm-enable-more-less-specific branch July 4, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants