feat: theme error page #39122
Merged
feat: theme error page #39122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
force-pushed
the
enh/themed-error-page
branch
from
785342c
to
e6370d2
Compare
st3iny
added
3. to review
st3iny
force-pushed
the
enh/themed-error-page
branch
from
e6370d2
to
b184859
Compare
Merged
ChristophWurst
approved these changes
Dec 4, 2023
skjnldsv
approved these changes
Feb 24, 2024
skjnldsv
added
4. to release
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
enh/themed-error-page
branch
from
b184859
to
f2e6aba
Compare
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The generic error page is not themed. Now it is. Perhaps this is a bit too hacky?
Why does it matter to theme an error page? Well, the generic error page (
printErrorPage) is shown to users even if the instance works correctly. E.g. when a password expires via the password_policy app. So theming it should be worth it.I kept the old unthemed page as a fallback in case dispatching the event fails.
Best reviewed with hidden white space changes: https://github.com/nextcloud/server/pull/39122/files?w=1
TODO
Checklist