Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files_sharing): hide download permission for circle shares #39146

Merged
merged 1 commit into from Jul 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions apps/files_sharing/src/components/SharingEntry.vue
Expand Up @@ -404,6 +404,12 @@ export default {
* @return {boolean}
*/
isSetDownloadButtonVisible() {
// TODO: Implement download permission for circle shares instead of hiding the option.
// https://github.com/nextcloud/server/issues/39161
if (this.share && this.share.type === this.SHARE_TYPES.SHARE_TYPE_CIRCLE) {
return false
}

const allowedMimetypes = [
// Office documents
'application/msword',
Expand Down
1 change: 0 additions & 1 deletion dist/2142-2142.js.map

This file was deleted.

6 changes: 3 additions & 3 deletions dist/2142-2142.js → dist/3832-3832.js

Large diffs are not rendered by default.

File renamed without changes.
1 change: 1 addition & 0 deletions dist/3832-3832.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/files_sharing-files_sharing_tab.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/files_sharing-files_sharing_tab.js.map

Large diffs are not rendered by default.