Refactors files app commands #39150
Merged
Refactors files app commands #39150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Psaml still failing with: |
@solracsf I was searching for the solution since it seems to be a Psalm false positive error. It does have a hacky solution indeed that I didn't like to be quite honest. In the end, I figured to just remove the return type from the method, as there are multiple similar methods in the codebase that do not have a return type and this way, the codebase remains consistent regarding the issue. |
szaimen
requested review from
icewind1991,
artonge,
come-nc,
a team and
ArtificialOwl
and removed request for
a team
artonge
approved these changes
Jul 12, 2023
artonge
force-pushed
the
refactor_files_app_commands
branch
from
636e740
to
fcd6f4e
Compare
To improve code readability. Signed-off-by: Faraz Samapoor <fsa@adlas.at>
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
I just removed the return type from the "exceptionErrorHandler". There is in fact a hacky solution, that I didn't like: vimeo/psalm#3571 Signed-off-by: Faraz Samapoor <fsa@adlas.at>
fsamapoor
force-pushed
the
refactor_files_app_commands
branch
from
fcd6f4e
to
270035f
Compare
come-nc
approved these changes
Aug 1, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Resolving conflicts with web ide messed things up. Gonna fix the issue and report back ASAP. |
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
fsamapoor
force-pushed
the
refactor_files_app_commands
branch
from
adcd7e4
to
b353b3f
Compare
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made some adjustments to the
apps/files/lib/Commandclasses to improve the code readability.The improvements in this PR include but are not limited to: