Migrate federated file sharing to PSR LoggerInterface #39160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Altahrim
force-pushed
the
fix/migrate-to-psr-logger-interface-federatedfilesharing
branch
2 times, most recently
from
4edde7b
to
65ae5cf
Compare
24 tasks
Altahrim
force-pushed
the
fix/migrate-to-psr-logger-interface-federatedfilesharing
branch
4 times, most recently
from
e61884c
to
b8295db
Compare
Altahrim
force-pushed
the
fix/migrate-to-psr-logger-interface-federatedfilesharing
branch
from
b8295db
to
0cda7d0
Compare
Altahrim
requested review from
a team,
ArtificialOwl,
icewind1991 and
come-nc
and removed request for
a team
come-nc
reviewed
Jul 6, 2023
apps/federatedfilesharing/lib/Controller/MountPublicLinkController.php
Outdated
Show resolved
Hide resolved
apps/federatedfilesharing/tests/Controller/MountPublicLinkControllerTest.php
Show resolved
Hide resolved
apps/federatedfilesharing/tests/Controller/MountPublicLinkControllerTest.php
Outdated
Show resolved
Hide resolved
Altahrim
force-pushed
the
fix/migrate-to-psr-logger-interface-federatedfilesharing
branch
from
0cda7d0
to
fd97966
Compare
come-nc
approved these changes
Jul 6, 2023
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Altahrim
force-pushed
the
fix/migrate-to-psr-logger-interface-federatedfilesharing
branch
from
fd97966
to
45b3f6e
Compare
artonge
approved these changes
Jul 11, 2023
Altahrim
deleted the
fix/migrate-to-psr-logger-interface-federatedfilesharing
branch
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #32127
Summary
Remove
OCP\ILoggerfromapps/federatedfilesharingand use Psr\Log\LoggerInterface` instead.