Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable all files_versions features when groupfolders is enabled #39165

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Jul 5, 2023

Fix #39137

-- Before After
In plain folder Screenshot from 2023-07-05 15-54-16 Screenshot from 2023-07-05 15-52-01
In group folder Screenshot from 2023-07-05 15-54-22 Screenshot from 2023-07-05 15-52-05

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge enabled auto-merge July 5, 2023 13:52
@artonge artonge self-assigned this Jul 5, 2023
@artonge artonge added enhancement 3. to review Waiting for reviews javascript php Pull requests that update Php code labels Jul 5, 2023
@artonge artonge added this to the Nextcloud 28 milestone Jul 5, 2023
@artonge
Copy link
Contributor Author

artonge commented Jul 5, 2023

/backport to stable27

@artonge
Copy link
Contributor Author

artonge commented Jul 5, 2023

/backport to stable26

@artonge artonge requested review from a team, susnux, Fenn-CS and Pytal and removed request for a team July 5, 2023 13:54
@artonge artonge changed the title Enable all files versions features when groupfolders is enabled Enable all files_versions features when groupfolders is enabled Jul 5, 2023
@artonge artonge merged commit 5538a40 into master Jul 6, 2023
40 checks passed
@artonge artonge deleted the artonge/feat/enable_versions_features_with_groupfolders_enabled branch July 6, 2023 11:11
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request enhancement javascript php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make persistent versioning available even with groupfolders being activated
5 participants