Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable26] fix(dav): Abort requests with 429 instead of waiting #39252

Merged
merged 1 commit into from Jul 10, 2023
Merged

[stable26] fix(dav): Abort requests with 429 instead of waiting #39252

merged 1 commit into from Jul 10, 2023

Conversation

nickvergessen
Copy link
Member

Backport #38046

@nickvergessen
fix(dav): Abort requests with 429 instead of waiting
ddff2e6 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Jul 10, 2023
@nickvergessen nickvergessen added this to the Nextcloud 26.0.4 milestone Jul 10, 2023
@nickvergessen nickvergessen self-assigned this Jul 10, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 10, 2023
View reviewed changes
apps/dav/lib/Connector/Sabre/Exception/TooManyRequests.php
// set ownCloud namespace
$errorNode->setAttribute('xmlns:o', self::NS_OWNCLOUD);

$error = $errorNode->ownerDocument->createElementNS('o:', 'o:hint', 'too many requests');

Check notice

Code scanning / Psalm

PossiblyNullReference Note

Cannot call method createElementNS on possibly null value
@nickvergessen nickvergessen merged commit a87a931 into stable26 Jul 10, 2023
37 checks passed
@nickvergessen nickvergessen deleted the backport/38046/stable26 branch July 10, 2023 12:30
@blizzz blizzz mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejo- mejo- mejo- approved these changes

@kesselb kesselb kesselb approved these changes

@bigcat88 bigcat88 bigcat88 approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@julien-nc julien-nc Awaiting requested review from julien-nc

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 26.0.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nickvergessen @mejo- @kesselb @bigcat88