Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud_federation_api: Add OpenAPI spec #39318

Merged
merged 2 commits into from Jul 13, 2023

Conversation

provokateurin
Copy link
Member

Summary

From #36666. Adds the necessary annotations and descriptions.

Also fixes some problems with responses that were not compliant with the spec at https://github.com/cs3org/OCM-API/blob/v1.0.0/spec.yaml.

Checklist

@provokateurin provokateurin added the 3. to review Waiting for reviews label Jul 11, 2023
@provokateurin provokateurin added this to the Nextcloud 28 milestone Jul 11, 2023
Signed-off-by: jld3103 <jld3103yt@gmail.com>
Signed-off-by: jld3103 <jld3103yt@gmail.com>
@provokateurin provokateurin force-pushed the feature/openapi/cloud_federation_api branch from 8f7ea56 to 6843bcd Compare July 13, 2023 05:21
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite being the main maintainer for this app since some weeks, I have to admit that I have zero clue about it so far. Code changes look legit to me with a minor comment.

@provokateurin provokateurin merged commit b6e73c8 into master Jul 13, 2023
36 of 37 checks passed
@provokateurin provokateurin deleted the feature/openapi/cloud_federation_api branch July 13, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants