Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files_external: Add OpenAPI spec #39321

Merged
merged 1 commit into from Jul 13, 2023
Merged

Conversation

provokateurin
Copy link
Member

Summary

From #36666. Adds the necessary annotations and descriptions.

Checklist

Signed-off-by: jld3103 <jld3103yt@gmail.com>
@provokateurin
Copy link
Member Author

@artonge @icewind1991 Can you help me with the CI failure? I don't see why my changes would cause any failure since they only add annotations which are completely ignored at runtime, thus no behavioral changes were made afaict

Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of those tests are triggered only when some specific files are edited.
They might be failing for a long time 🙈 .
As your changes are mostly comments, I think we can merge without further concern.
If @icewind1991 agrees, feel free to merge :)

@provokateurin
Copy link
Member Author

Yeah I already imagined something like that. There is no way the comments can break something

@icewind1991 icewind1991 merged commit c3c58b6 into master Jul 13, 2023
40 of 47 checks passed
@icewind1991 icewind1991 deleted the feature/openapi/files_external branch July 13, 2023 14:02
@icewind1991
Copy link
Member

S3 external test fix is here: #39367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants