feat: Add public event for missing indices #39389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
force-pushed
the
enh/add-missing-indices-event
branch
from
9040daa
to
bd59f7e
Compare
juliushaertl
added
2. developing
juliushaertl
force-pushed
the
enh/add-missing-indices-event
branch
from
bd59f7e
to
88870aa
Compare
juliushaertl
added
3. to review
nickvergessen
approved these changes
Jul 14, 2023
juliushaertl
force-pushed
the
enh/add-missing-indices-event
branch
from
88870aa
to
f9e5c3f
Compare
blizzz
approved these changes
Jul 14, 2023
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
enh/add-missing-indices-event
branch
from
f9e5c3f
to
925bceb
Compare
blizzz
added
4. to release
|
Failures unrelated |
|
/backport to stable27 |
|
/backport to stable26 |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Jul 14, 2023
juliushaertl
removed
the
pending documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a public event to allow apps registering missing indices. The event is dispatched for both the setup check as well as the occ db:add-missing-indices command and also works with dry run there to list the sql queries for manual migration.
Backports to 27/26 would be required for nextcloud/text#4522 and would be fine as text is bundled
Usage can be seen in nextcloud/text#4521
Checklist