Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n) Changed case of "Files" #39400

Merged
merged 2 commits into from Aug 1, 2023
Merged

fix(i18n) Changed case of "Files" #39400

merged 2 commits into from Aug 1, 2023

Conversation

rakekniven
Copy link
Member

Reported at Transifex.

@kesselb
Copy link
Contributor

kesselb commented Jul 17, 2023

/compile amend /

@rakekniven
Copy link
Member Author

Please merge.

@nickvergessen
Copy link
Member

@rakekniven in case you rebased because of this:
grafik

You only need/should do it when the branch is quite old/conflicted. It's not necessary to do it every day or even multiple times a day. That just delays CI

@skjnldsv
Copy link
Member

skjnldsv commented Aug 1, 2023

Please also fix tests

FAIL apps/files_sharing/src/actions/openInFilesAction.spec.ts
  ● Open in files action conditions tests › Default values

    expect(received).toBe(expected) // Object.is equality

    Expected: "Open in files"
    Received: "Open in Files"

      51 | 		expect(action).toBeInstanceOf(FileAction)
      52 | 		expect(action.id).toBe('open-in-files')
    > 53 | 		expect(action.displayName([], validViews[0])).toBe('Open in files')

rakekniven and others added 2 commits August 1, 2023 15:13
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 1, 2023
@nickvergessen nickvergessen merged commit 385f987 into master Aug 1, 2023
38 checks passed
@nickvergessen nickvergessen deleted the rakekniven-patch-1 branch August 1, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants