Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(a11y): User management settings dialog #39402

Merged
merged 3 commits into from Jul 21, 2023
Merged

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jul 15, 2023

Summary

Screenshot
Before image
After image image

Checklist

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal changed the title [WIP] Users settings modal enh(a11y): User management settings dialog Jul 19, 2023
@Pytal Pytal marked this pull request as ready for review July 19, 2023 03:41
@Pytal Pytal added this to the Nextcloud 28 milestone Jul 19, 2023
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Pytal for extracting modal elements to an extra component and cleaning up!
Unfortunately contrast issue for default theme is still there:

Screenshot from 2023-07-19 10-22-16
Screenshot from 2023-07-19 10-22-09

@szaimen
Copy link
Contributor

szaimen commented Jul 19, 2023

@JuliaKirschenheuter where is the contrast issue here? I think it looks fine? Can xou explain in words?

@susnux
Copy link
Contributor

susnux commented Jul 19, 2023

If it is about the focus state of the settings button, then it should be fixed on the nextcloud-vue library, as this does not introduce any custom styling there.

Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works but didnt review the code

@Pytal
Copy link
Member Author

Pytal commented Jul 19, 2023

Referring to the hover state in the second image @JuliaKirschenheuter? As a11y only concerns keyboard focus then I'd say that should be addressed separately with the design team

@Pytal Pytal merged commit 608ba17 into master Jul 21, 2023
42 checks passed
@Pytal Pytal deleted the enh/a11y-users-settings branch July 21, 2023 18:18
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 21, 2023
@Pytal
Copy link
Member Author

Pytal commented Jul 21, 2023

Feel free to suggest any followups @JuliaKirschenheuter :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility enhancement feature: users and groups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants