New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh(a11y): User management settings dialog #39402
Conversation
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
313fa60
to
8695e7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Pytal for extracting modal elements to an extra component and cleaning up!
Unfortunately contrast issue for default theme is still there:
@JuliaKirschenheuter where is the contrast issue here? I think it looks fine? Can xou explain in words? |
If it is about the focus state of the settings button, then it should be fixed on the nextcloud-vue library, as this does not introduce any custom styling there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works but didnt review the code
Referring to the hover state in the second image @JuliaKirschenheuter? As a11y only concerns keyboard focus then I'd say that should be addressed separately with the design team |
Feel free to suggest any followups @JuliaKirschenheuter :) |
Summary
Checklist