fix: check that object store backend supports multi part uploads

[kesselb]

• Resolves: MultipartUpload for uploading chunks to s3 may break other object store implementations #39088

Summary

A object store backend may not support multi part uploads.

TODO

• CI

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[kesselb]

/backport to stable27

[kesselb]

/backport to stable26

[artonge]

I thought we kept a fallback in those cases.

[kesselb]

I thought we kept a fallback in those cases.

That's correct.

The exception, thrown in checkPrerequisites, is handled in afterMkcol, beforeDelete, beforeMove and beforePut. If a file upload is taking the new path, ChunkingV2Plugin.beforePut returns false and prevent the old ChunkingPlugin to run.

[kesselb]

/backport to stable27

[kesselb]

/backport to stable26

[backportbot-nextcloud]

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[backportbot-nextcloud]

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[backportbot-nextcloud]

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[backportbot-nextcloud]

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[backportbot-nextcloud]

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[kesselb]

Backport 27: #39458
Backport 26: #39459

[max-nextcloud]

ChunkingV2Plugin.beforePut returns false

I think it returns true:
https://github.com/nextcloud/server/blob/master/apps/dav/lib/Upload/ChunkingV2Plugin.php#L149-L151

But I assume that still does the trick.

[kesselb]

If a file upload is taking the new path, ChunkingV2Plugin.beforePut returns false and prevent the old ChunkingPlugin to run.

The first part is the important one ;)

server/apps/dav/lib/Upload/ChunkingV2Plugin.php

Line 187 in 582e655

return false;

https://github.com/nextcloud/3rdparty/blob/1ff71da76e24d442afab28586072409ef3b9660e/sabre/event/lib/WildcardEmitterTrait.php#L90