Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correctly add module content type to script tags with versions #39456

Merged
merged 1 commit into from Jul 18, 2023
Merged

fix: Correctly add module content type to script tags with versions #39456

merged 1 commit into from Jul 18, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 18, 2023

Summary

When server is in production mode, scripts will be have a version query (...?v=....), in this case module js script were not delivered with the module content type.

Checklist

@susnux
fix: Correctly add module content type to script tags when scripts …
3b05760 
…with versions are used

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug 3. to review Waiting for reviews labels Jul 18, 2023
@susnux susnux added this to the Nextcloud 28 milestone Jul 18, 2023
@susnux susnux requested review from szaimen, a team, ArtificialOwl, icewind1991 and Fenn-CS and removed request for a team July 18, 2023 11:12
@susnux
Copy link
Contributor Author

susnux commented Jul 18, 2023

/backport to stable27

@susnux susnux mentioned this pull request Jul 18, 2023
Merged
26 tasks
szaimen
szaimen approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and makes nextcloud/logreader#936 work :)

@susnux susnux requested a review from come-nc July 18, 2023 12:17
@susnux
Copy link
Contributor Author

susnux commented Jul 18, 2023

Drone failure seems unrelated

@susnux susnux merged commit 6e41ebc into master Jul 18, 2023
36 of 37 checks passed
@susnux susnux deleted the fix/script-tag-for-module-js-with-version branch July 18, 2023 15:39
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@come-nc come-nc come-nc approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@susnux @szaimen @come-nc