fix(files): Adjust files favorite marker for vue file list being cropped #39483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rflow Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
design
szaimen
approved these changes
Jul 19, 2023
icewind1991
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the favorite marker for files, used in the vue part of the files app, looks cropped as the stroke used for a11y (contrast) does overflow the view box of the used SVG.
Also on hovering a line the stroke / outline of the favorite icon was not adjusted and looked a bit out of place.
Checklist