Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenAPI specs #39641

Merged
merged 1 commit into from Aug 3, 2023
Merged

Fix OpenAPI specs #39641

merged 1 commit into from Aug 3, 2023

Conversation

provokateurin
Copy link
Member

Summary

Some stuff I forgot to commit and small fixes for union types. A future CI will catch the former problems.

Checklist

Copy link
Member

@bigcat88 bigcat88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it a good idea to have such large description with an example of the reply?

@provokateurin
Copy link
Member Author

Sorry, I don't understand what you mean. Can you rephrase for me?

@bigcat88
Copy link
Member

I am about the part with the description: Output can look like this: ...

@provokateurin
Copy link
Member Author

Ah I see, that description isn't on me though. It's just extracted from the comment of the method.

Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a fix that will have to be done on each future generated OpenAPI specs?

@provokateurin
Copy link
Member Author

If the openapi-extractor is updated and the output is changed, yes. I will add it as a dev dependency and also setup CI. Then the tool will be upgraded by bumping the dependency and thus needing to regenerate the specs. I expect the updates to get less and less in the future as the output gets better and better.

Signed-off-by: jld3103 <jld3103yt@gmail.com>
@julien-nc julien-nc disabled auto-merge August 3, 2023 09:52
@julien-nc julien-nc merged commit 15e2ca2 into master Aug 3, 2023
34 of 37 checks passed
@julien-nc julien-nc deleted the fix/openapi branch August 3, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants