New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OpenAPI specs #39641
Fix OpenAPI specs #39641
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it a good idea to have such large description with an example of the reply?
Sorry, I don't understand what you mean. Can you rephrase for me? |
I am about the part with the description: Output can look like this: ... |
Ah I see, that description isn't on me though. It's just extracted from the comment of the method. |
3b551d0
to
e8924c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a fix that will have to be done on each future generated OpenAPI specs?
If the openapi-extractor is updated and the output is changed, yes. I will add it as a dev dependency and also setup CI. Then the tool will be upgraded by bumping the dependency and thus needing to regenerate the specs. I expect the updates to get less and less in the future as the output gets better and better. |
Signed-off-by: jld3103 <jld3103yt@gmail.com>
e8924c1
to
89c941f
Compare
Summary
Some stuff I forgot to commit and small fixes for union types. A future CI will catch the former problems.
Checklist