Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(3rdparty): update symfony/mailer to 5.4.22 #39662

Merged
merged 1 commit into from Aug 4, 2023
Merged

chore(3rdparty): update symfony/mailer to 5.4.22 #39662

merged 1 commit into from Aug 4, 2023

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Aug 1, 2023 •
edited

Summary

Update symfony mailer to 5.4.22.

TODO

Checklist

@kesselb kesselb self-assigned this Aug 1, 2023
@kesselb kesselb added 3. to review Waiting for reviews dependencies labels Aug 1, 2023
mejo-
mejo- approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To rephrase Joas' words: "the CI is happy, so am I".

@kesselb
Copy link
Contributor Author

kesselb commented Aug 2, 2023

/update-3rdparty

@kesselb kesselb force-pushed the 3rdparty-bump-symfony-mailer branch from a6b4045 to 7a819f2 Compare August 2, 2023 14:15
@kesselb kesselb added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 2, 2023
@come-nc
Copy link
Contributor

come-nc commented Aug 3, 2023

/update-3rdparty

Some day we’ll get it right :-(

It seems ${{ github.event.issue.pull_request.base.ref }} was empty instead of being master: https://github.com/nextcloud/server/actions/runs/5739770063/job/15556134168

@kesselb
chore(3rdparty): update symfony/mailer to 5.4.22
6c67554 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the 3rdparty-bump-symfony-mailer branch from 7a819f2 to 6c67554 Compare August 3, 2023 13:34
@nickvergessen
Copy link
Member

unit test is fixed in #39705

@nickvergessen nickvergessen merged commit 7d9a321 into master Aug 4, 2023
36 of 37 checks passed
@nickvergessen nickvergessen deleted the 3rdparty-bump-symfony-mailer branch August 4, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejo- mejo- mejo- approved these changes

@come-nc come-nc come-nc approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@kesselb kesselb

Labels
4. to release Ready to be released and/or waiting for tests to finish dependencies
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kesselb @come-nc @nickvergessen @mejo-