Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove version check for apc extension #39723

Merged
merged 1 commit into from Aug 10, 2023
Merged

chore: remove version check for apc extension #39723

merged 1 commit into from Aug 10, 2023

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Aug 5, 2023 •
edited

  • Resolves: 馃Ч

Summary

APC is gone since PHP 7.0.

TODO

  • CI

Checklist

@kesselb kesselb self-assigned this Aug 5, 2023
@kesselb kesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 5, 2023
@kesselb kesselb requested review from GretaD, MichaIng, a team, ArtificialOwl, icewind1991 and Fenn-CS and removed request for a team August 5, 2023 16:49
@kesselb kesselb marked this pull request as ready for review August 5, 2023 16:50
@MichaIng MichaIng added this to the Nextcloud 28 milestone Aug 6, 2023
@kesselb kesselb added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 7, 2023
@kesselb
chore: remove version check for apc extension
7cab582 
APC is gone since PHP 7.0.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the removed-apc-extension-version-check branch from ba1fd1a to 7cab582 Compare August 10, 2023 13:02
@kesselb kesselb merged commit 51833a5 into master Aug 10, 2023
39 checks passed
@kesselb kesselb deleted the removed-apc-extension-version-check branch August 10, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

@MichaIng MichaIng MichaIng approved these changes

@GretaD GretaD Awaiting requested review from GretaD

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-backend

Assignees

@kesselb kesselb

Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kesselb @icewind1991 @MichaIng