Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always use display name from correct backend #39770

Merged

Commits on Aug 15, 2023

  1. fix: always use display name from correct backend

    Overwrite the display name after the account is initialized
    when using an instacne of IGetDisplayNameBackend.
    
    Before when using a variation of user_oidc and registering
    a Backend.php implementing IGetDisplayNameBackend
    the personal setting page shows 'uid'.
    
    The UserManager/AccountManager seems not to use consistently
    the correct backend.
    
    The correct backend is used in this sequence:
    
    server/lib/private/TemplateLayout.php
    
              $userDisplayName = \OC_User::getDisplayName();
              $this->assign(user_displayname, $userDisplayName);
    
    In the settings page, it definitely not calls the registered backend,
    but seems to fall back to default Backend and shows (usually) uid
    or a value from the standard account property table.
    
    Signed-off-by: Max <max@nextcloud.com>
    max-nextcloud committed Aug 15, 2023
    Copy the full SHA
    99a4a9c View commit details
    Browse the repository at this point in the history