[stable27] Vue based FilePicker #39793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyScherzinger
approved these changes
Aug 10, 2023
susnux
force-pushed
the
feat/vue-filepicker-27
branch
3 times, most recently
from
2e35020
to
79fff14
Compare
Pytal
approved these changes
Aug 10, 2023
…default. Still providing the legacy one until the Vue FilePicker is out of beta. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/vue-filepicker-27
branch
from
23e5f50
to
376f46e
Compare
| @@ -42,7 +42,7 @@ | |||
| "@nextcloud/browserslist-config": "^2.3.0", | |||
| "@nextcloud/calendar-availability-vue": "^0.6.0-alpha1", | |||
| "@nextcloud/capabilities": "^1.0.4", | |||
| "@nextcloud/dialogs": "^4.0.0-beta.2", | |||
| "@nextcloud/dialogs": "^4.2.0-beta.1", | |||
There was a problem hiding this comment.
Bump to beta.2 if possible
|
@Pytal would you be around to bump the lib to beta.2, see my review comment? |
3 tasks
|
Nice, thanks @susnux |
|
@susnux was it necessary to add |
|
We should probably add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to #39792 (manual backport)
Checklist