Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuse l10n and request in dav folder listing #39864

Merged
merged 1 commit into from Sep 4, 2023
Merged

Conversation

icewind1991
Copy link
Member

instead of having to query those once for every node

saved 15-20% when loading large folders during local testing: https://blackfire.io/profiles/compare/d33a9993-e3a4-4ea4-b9f2-f1b38f576937/graph

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Aug 14, 2023
@icewind1991 icewind1991 added this to the Nextcloud 28 milestone Aug 14, 2023
@icewind1991 icewind1991 requested review from a team, ArtificialOwl, blizzz and Fenn-CS and removed request for a team August 14, 2023 14:13
@icewind1991 icewind1991 force-pushed the dav-reuse-request branch 4 times, most recently from b6d4bb9 to 30209ea Compare August 15, 2023 13:51
@icewind1991
Copy link
Member Author

/backport to stable27

instead of having to query those once for every node

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 merged commit 9053eea into master Sep 4, 2023
40 checks passed
@icewind1991 icewind1991 deleted the dav-reuse-request branch September 4, 2023 13:57
@icewind1991
Copy link
Member Author

/backport to stable26

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@icewind1991
Copy link
Member Author

/backport to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants