Fix php 8.3 support in tests #39866
Merged
Fix php 8.3 support in tests #39866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Fixing 32bit CI on PHP>=8.3 Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
changed the title
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
requested review from
marcelklehr,
kesselb,
a team,
ArtificialOwl,
icewind1991 and
blizzz
and removed request for
a team
icewind1991
approved these changes
Aug 14, 2023
kesselb
reviewed
Aug 14, 2023
| @@ -656,7 +656,7 @@ public function testGetDenormalizedData($expected, $key, $calData): void { | |||
| try { | |||
| $actual = $this->backend->getDenormalizedData($calData); | |||
| $this->assertEquals($expected, $actual[$key]); | |||
| } catch (\ValueError $e) { | |||
| } catch (\Throwable $e) { | |||
There was a problem hiding this comment.
Suggested change
| } catch (\Throwable $e) { | |
| } catch (\ValueError|\DateRangeError $e) { |
Maybe?
kesselb
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picks from #39796 to improve PHP 8.3 support of our test suite.
Checklist