Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent PHP warning when CacheEntry extension keys are not set #39906

Merged
merged 2 commits into from Aug 17, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 16, 2023

Summary

Prevent warning when CacheEntry extensions are not set, for example prevents this:
Attachment file 1 Error detail(4)

Checklist

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added the 3. to review Waiting for reviews label Aug 16, 2023
@susnux susnux requested review from a team, ArtificialOwl, blizzz, Fenn-CS and icewind1991 and removed request for a team August 16, 2023 12:19
@susnux susnux changed the title Fix/prevent warnings if attr unset Prevent PHP warning when CacheEntry extension keys are not set Aug 16, 2023
@susnux susnux requested a review from Altahrim August 16, 2023 15:33
@susnux
Copy link
Contributor Author

susnux commented Aug 16, 2023

/backport to stable27

@susnux
Copy link
Contributor Author

susnux commented Aug 16, 2023

/backport to stable26

@susnux susnux added this to the Nextcloud 28 milestone Aug 16, 2023
@solracsf

This comment was marked as resolved.

@susnux
Copy link
Contributor Author

susnux commented Aug 17, 2023

/backport to stable25

@susnux susnux merged commit 1406eec into master Aug 17, 2023
37 of 38 checks passed
@susnux susnux deleted the fix/prevent-warnings-if-attr-unset branch August 17, 2023 09:31
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants