fix(settings): focus lost on selects in users settings

[ShGKme]

• Resolves: Similar to [BITV] 9.2.1.1/3.2 - The "Details" area - The combobox for selecting "Tags" is not fully usable with the keyboard. (2) #36980, but in User Settigns.

Summary

After adding/removing groups the focus is lost from NcSelect. You need to catch the select again with tab. This happens because during loading the NcSelect become disabled and cannot handle focus. To fix - remove disabling on loading state.

Also fixed some very minor issues in this component.

🖼️ Screenshots

Before	After

Todo

• Don't disable NcSelects on loading, only keep its loading state
• Minor fixes
  • Fix loading indicator of user manager update (lost await)
  • Fix label set user manager label

Drawbacks

Now NcSelect is still available during the loading, so the user can add a new group or delete a group. But it should work fine and it is the same as what we have with collaborative tags in the Files sidebar.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[JuliaKirschenheuter]

should we remove

server/apps/settings/src/components/Users/UserRow.vue

Lines 385 to 392 in d8d9567

	groups: false,
	subadmins: false,
	quota: false,
	delete: false,
	disable: false,
	languages: false,
	wipe: false,
	manager: false,

and all other related code for this.idState.xxx

server/apps/settings/src/components/Users/UserRow.vue

Line 732 in d8d9567

this.idState.loading.groups = true

too?

[JuliaKirschenheuter]

Thank you!

I guess a text here doesn't have enough contrast ;(

Is it an issue of NcSelect?

[ShGKme]

should we remove

It is still used for loading indicators, I only remove its usage from :disable

[ShGKme]

Is it an issue of NcSelect?

Yes...

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22