Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(memcache): Fix comparison of Memcache configs to classes #39910

Merged
merged 1 commit into from Aug 17, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Aug 16, 2023

Summary

In some cases we compared the cache class with a string starting \ and in some others with the ::class which does not have the leading \, so depending on the config value certain bits of functionality would kick in or not.
Now I'm aligning the class names to be without leading \ so we can always compare to ::class

Checklist

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Aug 16, 2023
@nickvergessen nickvergessen added this to the Nextcloud 28 milestone Aug 16, 2023
@nickvergessen nickvergessen self-assigned this Aug 16, 2023
@nickvergessen
Copy link
Member Author

/backport to stable27

@nickvergessen
Copy link
Member Author

nickvergessen commented Aug 16, 2023

/backport to stable26

@nickvergessen
Copy link
Member Author

/backport to stable25

@nickvergessen nickvergessen requested review from a team, ArtificialOwl and blizzz and removed request for a team August 16, 2023 14:07
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@nickvergessen nickvergessen merged commit a98748e into master Aug 17, 2023
37 of 38 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/fix-memcache-class-handling branch August 17, 2023 20:53
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants