[stable27] fix(files): Fix legacy files list sorting #39919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
skjnldsv,
a team,
artonge and
Pytal
and removed request for
a team
|
/backport to stable27 |
susnux
force-pushed
the
fix/legacy-files-list-sorting
branch
from
921fd9b
to
a1699a3
Compare
|
@skjnldsv after f2v this is not required on master, but we need this for stable27. |
susnux
force-pushed
the
fix/legacy-files-list-sorting
branch
from
a1699a3
to
40dec98
Compare
skjnldsv
previously requested changes
Aug 17, 2023
There was a problem hiding this comment.
Let's wait for #39808 please 🙏
That way you can also use the cypress selectors
https://github.com/nextcloud/server/blob/feat/f2v/files/cypress/e2e/files.cy.ts
susnux
force-pushed
the
fix/legacy-files-list-sorting
branch
from
40dec98
to
e79509a
Compare
susnux
requested review from
provokateurin,
ChristophWurst,
miaulalala,
nickvergessen,
st3iny,
JuliaKirschenheuter,
julien-nc,
come-nc,
ArtificialOwl,
icewind1991,
Fenn-CS and
tcitworld
as code owners
susnux
requested review from
skjnldsv
and removed request for
provokateurin,
ChristophWurst,
miaulalala,
nickvergessen,
st3iny,
JuliaKirschenheuter,
julien-nc,
come-nc,
ArtificialOwl,
icewind1991 and
tcitworld
|
Changed the base to stable27, as this is no longer needed for master (thanks to f2v :) ). Sorry for the noise Github assigned everyone for a short moment... |
susnux
changed the title
AndyScherzinger
approved these changes
Aug 18, 2023
artonge
approved these changes
Aug 18, 2023
susnux
force-pushed
the
fix/legacy-files-list-sorting
branch
from
e79509a
to
5a20f0f
Compare
The sorting was not saved since files2vue changes in Nextcloud 27, as a new API endpoint was introduced and the old one was dropped without adjusting the legacy file list to use it. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/legacy-files-list-sorting
branch
from
5a20f0f
to
cb5c172
Compare
8 tasks
|
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The sorting was not saved since files2vue changes in Nextcloud 27, as a new API endpoint was introduced and the old one was dropped without adjusting the legacy file list to use it.
Checklist