New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix predefined status buttons #39987
Fix predefined status buttons #39987
Conversation
@marcoambrosini what do you think of the style? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the border is fine, but I think we should put the radio button symbol too @JuliaKirschenheuter
I'm afraid that we're confusing people a lot with these radio buttons that don't look like radios.
yes, i'm agree that this buttons are not really radio buttons. But let them be radio buttons for now. We had only an issue that they are not really recognizable.
I think then it will be lots of "flashing elements". A11y-wise it is not required. If border is ok - could we leave it like this for now? All improvements we can do afterwards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JuliaKirschenheuter let's add a normal border radius and get this in, going forward I think we should add the radio button (which is now .hidden-visually
) to all radio buttons
do you mean the same border radius like in "online status"? |
Yes @JuliaKirschenheuter |
Add styles for radio buttons to be visible in checked, active and focus-visible state. Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
ae7e7f1
to
558f5f9
Compare
Summary
Checklist