[stable27] feat(security): Add a bruteforce protection backend base on memcache #39997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
enhancement
3. to review
nickvergessen
requested review from
AndyScherzinger,
Altahrim,
artonge and
bigcat88
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -909,6 +914,8 @@ | |||
| 'cronInfo' => $this->getLastCronInfo(), | |||
| 'cronErrors' => $this->getCronErrors(), | |||
| 'isFairUseOfFreePushService' => $this->isFairUseOfFreePushService(), | |||
| 'isBruteforceThrottled' => $this->throttler->getAttempts($this->request->getRemoteAddress()) !== 0, | |||
Check notice
Code scanning / Psalm
DeprecatedMethod Note
skjnldsv
approved these changes
Aug 22, 2023
AndyScherzinger
approved these changes
Aug 22, 2023
Similar to the ratelimit backend Signed-off-by: Joas Schilling <coding@schilljs.com>
…oesn't sleep Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Calling setHeaders(getHeaders()) breaks the CSP nonce for unknown reasons So shifting back to old standard practise for now Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
backport/39870/stable27
branch
from
a796887
to
26832ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #39870
Backport of #39996