Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(files): add drag and drop support #39998

Merged
merged 4 commits into from Sep 26, 2023
Merged

feat(files): add drag and drop support #39998

merged 4 commits into from Sep 26, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 22, 2023

Informations

This PR adds drag and dro psupport for files

Bug

  • The loading indicator seems broken, this is a vue reactivity issue that will be fixed later, this is not related to this PR :)

Ref #39914

Fix #18850
Fix #37658
Fix #5356

  • Move mechanism (bind to the move action?)
  • Visual feedback

@skjnldsv skjnldsv added this to the Nextcloud 28 milestone Aug 22, 2023
@skjnldsv skjnldsv self-assigned this Aug 22, 2023
@skjnldsv skjnldsv added this to In progress in Files to vue via automation Aug 22, 2023
@skjnldsv skjnldsv mentioned this pull request Aug 24, 2023
26 tasks
@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 5, 2023

@nextcloud/designers I'm close to finish this and a question popped up. When selecting a big set of files and folder, maybe it would be safe to have an alert and ask confirmation before drag-dropping to another folder? Because we currently have no cancellation button, so if you misclick and drop to another folder, might have bad outcomes? 🤔

@marcoambrosini
Copy link
Member

When selecting a big set of files and folder, maybe it would be safe to have an alert and ask confirmation before drag-dropping to another folder?

@skjnldsv Without a toggle for this in the settings, I'm afraid this could get in the way of people who are sure about what they're doing

@skjnldsv skjnldsv force-pushed the feat/f2v/dnd branch 2 times, most recently from cee3ab2 to 7b59fa3 Compare September 22, 2023 08:38
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 22, 2023
@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 22, 2023

@skjnldsv Without a toggle for this in the settings, I'm afraid this could get in the way of people who are sure about what they're doing

When dragging 100+ files, any confirmation is better than a potential destructive outcome, no? cc @jancborchardt

@skjnldsv skjnldsv marked this pull request as ready for review September 23, 2023 09:24
apps/files/src/actions/moveOrCopyAction.ts Outdated Show resolved Hide resolved
apps/files/src/actions/moveOrCopyAction.ts Outdated Show resolved Hide resolved
apps/files/src/actions/moveOrCopyAction.ts Show resolved Hide resolved
apps/files/src/actions/moveOrCopyAction.ts Show resolved Hide resolved
apps/files/src/actions/moveOrCopyAction.ts Outdated Show resolved Hide resolved
apps/files/src/components/FileEntry.vue Outdated Show resolved Hide resolved
apps/files/src/components/FileEntry.vue Outdated Show resolved Hide resolved
apps/files/src/components/FileEntry.vue Outdated Show resolved Hide resolved
apps/files/src/components/FileEntry.vue Outdated Show resolved Hide resolved
@skjnldsv skjnldsv force-pushed the feat/f2v/dnd branch 2 times, most recently from 3ee3360 to df8e040 Compare September 26, 2023 12:21
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit d395fa8 into master Sep 26, 2023
34 of 36 checks passed
Files to vue automation moved this from In progress to Done Sep 26, 2023
@delete-merged-branch delete-merged-branch bot deleted the feat/f2v/dnd branch September 26, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Files to vue
  
Done
4 participants