Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable27] fix(utility): De- deprecate getDateTime and getTime as now() only returns DateTimeImmutable #40039

Merged
merged 1 commit into from Aug 29, 2023
Merged

[stable27] fix(utility): De- deprecate getDateTime and getTime as now() only returns DateTimeImmutable #40039

merged 1 commit into from Aug 29, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #39511

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 27.1.0 milestone Aug 25, 2023
@miaulalala
fix(utility): De- deprecate getDateTime as now() only returns immutab…
5133711 
…le objects

This will mean lots of code like
```$dateTime = (new DateTime())->setTimestamp(ITimeFactory::now()->getTimestamp()```
if a regular DateTime object is needed

Signed-off-by: Anna Larch <anna@nextcloud.com>
@blizzz blizzz mentioned this pull request Aug 29, 2023
Merged
@nickvergessen nickvergessen merged commit ff0569a into stable27 Aug 29, 2023
36 checks passed
@nickvergessen nickvergessen deleted the backport/39511/stable27 branch August 29, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@Altahrim Altahrim Altahrim approved these changes

@bigcat88 bigcat88 Awaiting requested review from bigcat88

@miaulalala miaulalala Awaiting requested review from miaulalala

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Nextcloud 27.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nickvergessen @Altahrim @miaulalala