[Devcontainer] move git setup to postStartCommand #40068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
approved these changes
Aug 28, 2023
kesselb
added
4. to release
R0Wi
force-pushed
the
devcontainer-fix-git-config
branch
from
1dae47f
to
ff45fbf
Compare
|
@kesselb I guess the CI failures are unrelated? |
Most likely. |
susnux
force-pushed
the
devcontainer-fix-git-config
branch
from
ff45fbf
to
f74a12c
Compare
|
@R0Wi would you mind to sign you commit so it passed the DCO check? :) |
* postCreateCommand is executed too early * If git config commands run in postCreate, a global .gitconfig will be created * Copy of local .gitconfig will be skipped if .gitconfig already exists in container * Move to later stage * devcontainers/cli#98 * microsoft/vscode-remote-release#4855 (comment) Signed-off-by: GitHub <noreply@github.com>
R0Wi
force-pushed
the
devcontainer-fix-git-config
branch
from
f74a12c
to
9dd158b
Compare
|
@susnux done ✔️ |
|
Drone unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem summary
If you create a new devcontainer (locally), you will find the following in the logs:
Like shown, the
git config --globalcommands executed insetup.shwill create the file/home/devcontainer/.gitconfigwhich will prevent that the.gitconfigof the local user gets copied to the devcontainer. A similar issue is described here: devcontainers/cli#98.If you for example execute
git config --global user.nameafter the container has been created, you will see that the username is empty and not set to the local git user of the host system.Fix
The fix here moves the
git config --globalcommands to a later setup stage. The logs will now look like the following (see also microsoft/vscode-remote-release#4855 (comment)):Now
git config --global user.nameoutputsRobin Windeyin my case.Copying the local git settings into the container is usually necessary to execute
git commit(and git signing).