Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust input field for "rename group" #40087

Merged
merged 1 commit into from Aug 31, 2023
Merged

Adjust input field for "rename group" #40087

merged 1 commit into from Aug 31, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Aug 29, 2023 •
edited

Part of #37082
⚠️ Blocked by #40084

Summary

Before After
Screenshot from 2023-08-28 18-53-09 Screenshot from 2023-08-29 10-24-27

Checklist

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Aug 29, 2023
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Aug 29, 2023
@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Aug 29, 2023
Closed
ShGKme
ShGKme approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Let's wait for the blocking PR merge

@JuliaKirschenheuter
Adjust input field for "rename group"
6e6bf2a 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/37082-fix-label_for_creating_new_group branch from 444659e to 6e6bf2a Compare August 31, 2023 09:43
@AndyScherzinger AndyScherzinger merged commit 339576f into master Aug 31, 2023
38 of 39 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/37082-fix-label_for_creating_new_group branch August 31, 2023 15:12
@AndyScherzinger AndyScherzinger added this to the Nextcloud 28 milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@Pytal Pytal Pytal approved these changes

@ShGKme ShGKme ShGKme approved these changes

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JuliaKirschenheuter @artonge @Pytal @ShGKme @AndyScherzinger