Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable caldav push notifications by default #40103

Merged
merged 1 commit into from Sep 13, 2023
Merged

Enable caldav push notifications by default #40103

merged 1 commit into from Sep 13, 2023

Conversation

hamza221
Copy link
Contributor

Summary

Checklist

@hamza221 hamza221 added enhancement 3. to review Waiting for reviews feature: dav feature: caldav Related to CalDAV internals labels Aug 29, 2023
@hamza221 hamza221 self-assigned this Aug 29, 2023
@tcitworld
Copy link
Member

Reverting everything, not just changing the default value of the setting?

@hamza221
Copy link
Contributor Author

Reverting everything, not just changing the default value of the setting?

In the issue #39862 the solution is reverting but I think this #39158 would be the next step

@tcitworld
Copy link
Member

I don't understand how it answers #39158, sorry. :(

@hamza221
Copy link
Contributor Author

I don't understand how it answers #39158, sorry. :(

it doesn't, it answers #39862

GretaD
GretaD approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i only checked the vue and js changes

@hamza221 hamza221 force-pushed the enh/enable-caldav-push-notifications-by-default branch from d84a49c to 5193cd5 Compare August 31, 2023 13:09
ChristophWurst
ChristophWurst requested changes Sep 6, 2023
View reviewed changes
apps/dav/lib/CalDAV/Reminder/NotificationProvider/PushProvider.php
@@ -82,10 +82,6 @@ public function send(VEvent $vevent,
?string $calendarDisplayName,
array $principalEmailAddresses,
array $users = []):void {
if ($this->config->getAppValue('dav', 'sendEventRemindersPush', 'no') !== 'yes') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like @tcitworld said we should flip the default value but leave the option to turn the feature off

@hamza221 hamza221 force-pushed the enh/enable-caldav-push-notifications-by-default branch from 5193cd5 to c9e5dbd Compare September 8, 2023 14:32
@ChristophWurst
Copy link
Member

Failure of OCA\DAV\Tests\unit\CalDAV\Reminder\NotificationProvider\PushProviderTest::testNotSend and similar are related

@ChristophWurst ChristophWurst mentioned this pull request Sep 12, 2023
Closed
ChristophWurst
ChristophWurst approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time to squash

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 12, 2023
@hamza221
Enable caldav push notifications by default
823908b 
Signed-off-by: hamza221 <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 force-pushed the enh/enable-caldav-push-notifications-by-default branch from 4d778a7 to 823908b Compare September 12, 2023 11:58
@hamza221 hamza221 merged commit 4f0a151 into master Sep 13, 2023
38 checks passed
@hamza221 hamza221 deleted the enh/enable-caldav-push-notifications-by-default branch September 13, 2023 08:50
@AndyScherzinger AndyScherzinger added this to the Nextcloud 28 milestone Sep 14, 2023
@susnux susnux mentioned this pull request Sep 17, 2023
Closed
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Feb 6, 2024
@ChristophWurst
Copy link
Member

Needs admin docs for how to set sendEventRemindersPush and an entry in the admin upgrade section for 28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@tcitworld tcitworld tcitworld approved these changes

@miaulalala miaulalala miaulalala approved these changes

@GretaD GretaD GretaD approved these changes

Assignees

@hamza221 hamza221

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: caldav Related to CalDAV internals feature: dav pending documentation This pull request needs an associated documentation update
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

Enable caldav push notifications by default
6 participants
@hamza221 @tcitworld @ChristophWurst @miaulalala @GretaD @AndyScherzinger