[stable26] feat: add switch to disable dns pinning #40167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OC\Files\Cache\Cache::get can return string|false|null, not just string|false. - #26270 added handling of false, but null is needed too. - Well, or we change the default $resullt to false, but I'm not sure if that has other ramifications and the real need here is to simply catch situations where the cache source storage path is not valid for whatever reason Related: #19009 Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
Co-authored-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Anna Larch <anna@nextcloud.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Altahrim
approved these changes
Aug 31, 2023
If 'verify_bucket_exists' is set to false in the config.php s3 configuration, it's supposed to avoid verifying that the bucket exists. However empty(falsy) will always return true, so this condition would not work. Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
this way we only have to determine the share permissions once Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Merged
[stable26] Catch more invalid cache source storage paths
[stable26] fix: close cursor after reading the invitation
[stable26] fix(s3): fix handling verify_bucket_exists parameter
[26] move share permission logic to storage wrapper
…logging [stable26] Do not log passwords in debug mode
[stable26] fix(cache): Remove displayname cache entry on delete
blizzz
approved these changes
Sep 6, 2023
[stable26] feat: add switch to disable dns pinning
|
@kesselb could you rebase, please, cannot merge due to conflicts. |
blizzz
added
4. to release
|
For the record, Github is wrong, this was merged:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #40108