Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(a11y): Add accessible user menu semantics #40168

Merged
merged 5 commits into from Oct 16, 2023
Merged

enh(a11y): Add accessible user menu semantics #40168

merged 5 commits into from Oct 16, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Aug 30, 2023 •
edited

Summary

  • Wrap menu trigger button in nav container
  • Add distinct label to app menu navigation landmark
  • Add user status to accessible name i.e. "Avatar of John — Online — 📅 — In a meeting"
  • Test with NVDA

No visual changes

Checklist

@Pytal Pytal added this to the Nextcloud 28 milestone Aug 30, 2023
@Pytal Pytal self-assigned this Aug 30, 2023
@Pytal Pytal mentioned this pull request Aug 30, 2023
Closed
13 tasks
@Pytal Pytal changed the title [WIP] enh(a11y): Add accessible user menu semantics enh(a11y): Add accessible user menu semantics Oct 11, 2023
@Pytal Pytal marked this pull request as ready for review October 12, 2023 00:05
@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 12, 2023
@szaimen szaimen removed their request for review October 12, 2023 10:41
@szaimen

This comment was marked as resolved.

Sign in to view
susnux
susnux approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree the the note of @ShGKme but otherwise looks fine

@Pytal Pytal requested a review from artonge October 12, 2023 17:19
JuliaKirschenheuter
JuliaKirschenheuter approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you!

@Pytal

This comment was marked as outdated.

Sign in to view
@Pytal
Copy link
Member Author

Pytal commented Oct 13, 2023

Otherwise we're good to go

@Pytal
enh(a11y): Add accessible user menu semantics
6c5a10f 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
enh(a11y): Add avatar description
f2f1e9c 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
enh(a11y): Add label to app menu nav
a7de113 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix(acceptance): Locate settings menu
0b8958f 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: compile assets
48e02be 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Copy link
Member Author

Pytal commented Oct 16, 2023

CI failures unrelated

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 16, 2023
@Pytal Pytal merged commit e6a2985 into master Oct 16, 2023
37 of 40 checks passed
@Pytal Pytal deleted the enh/a11y/user-menu branch October 16, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme left review comments

@susnux susnux susnux approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@artonge artonge Awaiting requested review from artonge

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility feature: settings
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Pytal @szaimen @susnux @JuliaKirschenheuter @ShGKme